Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22894#discussion_r229776086
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -189,13 +190,12 @@ private[spark] class HighlyCompressedMapStatus 
private (
         emptyBlocks.readExternal(in)
         avgSize = in.readLong()
         val count = in.readInt()
    -    val hugeBlockSizesArray = mutable.ArrayBuffer[Tuple2[Int, Byte]]()
    +    hugeBlockSizes = new util.HashMap[Int, Byte](count).asScala
    --- End diff --
    
    How about just scala's mutable Map? I'd expect it's no slower than Java's, 
given it might specialize for primitives (not sure about this) and sometimes 
has smarter implementations internally.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to