Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22894#discussion_r231125168
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -149,7 +150,7 @@ private[spark] class HighlyCompressedMapStatus private (
         private[this] var numNonEmptyBlocks: Int,
         private[this] var emptyBlocks: RoaringBitmap,
         private[this] var avgSize: Long,
    -    private var hugeBlockSizes: Map[Int, Byte])
    +    private[this] var hugeBlockSizes: mutable.Map[Int, Byte])
    --- End diff --
    
    I like that possibility. If the cost of wrapping/building an immutable map 
isn't higher, it's better.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to