Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22894#discussion_r231122195
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -149,7 +150,7 @@ private[spark] class HighlyCompressedMapStatus private (
private[this] var numNonEmptyBlocks: Int,
private[this] var emptyBlocks: RoaringBitmap,
private[this] var avgSize: Long,
- private var hugeBlockSizes: Map[Int, Byte])
+ private[this] var hugeBlockSizes: mutable.Map[Int, Byte])
--- End diff --
It's mutated though, and needs to be mutable. If it were exposed outside
the class, or there was significant danger of accidentally mutating it
elsewhere, I think it might be necessary to wrap the result in an immutable
wrapper, but here this seems OK to me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
