Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3548#discussion_r21142257
--- Diff:
core/src/main/scala/org/apache/spark/deploy/master/ApplicationInfo.scala ---
@@ -43,9 +43,12 @@ private[spark] class ApplicationInfo(
@transient var coresGranted: Int = _
@transient var endTime: Long = _
@transient var appSource: ApplicationSource = _
+ @transient var lastHeartbeat: Long = _
@transient private var nextExecutorId: Int = _
+ val failureDetector = new ApplicationFailureDetector(desc.name, id)
--- End diff --
I considered that, but that's one more map entry to remember to garbage
collect when cleaning up applications. Also, the old state for this used to be
in ApplicationInfo, so I don't think it's inconsistent to keep the new
encapsulation of that state there, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
