Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/3548#issuecomment-65191401
  
    I'm working on pulling in 
[SPARK-2424](https://issues.apache.org/jira/browse/SPARK-2424) as well, but 
I've run into one minor naming snag: what do I call the new threshold?  I 
thought of `maxConsecutiveExecutorFailures` but that name is kind of misleading 
since it implies that the application will always be terminated if more than 
that many failures occur, which isn't _always_ the case (an application which 
reports that it has at least one registered executor will _never_ be terminated 
by this mechanism).  If we want to be _really_ specific, I suppose that 
`minConsecutiveExecutorFailuresBeforeAppFailure` is better, since it conveys 
that _at least_ that many failures must occur before we will consider killing 
the app.  That's too long, though.  Anyone have a quick suggestion for a better 
name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to