Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3548#discussion_r21143563
--- Diff:
core/src/main/scala/org/apache/spark/deploy/client/AppClient.scala ---
@@ -111,6 +123,20 @@ private[spark] class AppClient(
case x =>
throw new SparkException("Invalid spark URL: " + x)
}
+ import context.dispatcher
+ // Cancel any existing heartbeat timer
+ heartbeatTimer.foreach(_.cancel())
+ // Start a new master heartbeat timer
+ heartbeatTimer = Some(
+ context.system.scheduler.schedule(heartbeatInterval,
heartbeatInterval) {
+ if (master != null) { // guard against race condition while
switching masters
--- End diff --
Checked the docs and can confirm that we should be sending a self-message:
http://doc.akka.io/docs/akka/snapshot/scala/scheduler.html#Some_examples. I'll
fix this up now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
