Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/3636#discussion_r21480898 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala --- @@ -77,6 +80,14 @@ class GradientDescent private[mllib] (private var gradient: Gradient, private va } /** + * Set the convergence tolerance. Default 0.0 --- End diff -- It would be good to note what convergence tolerance is. In particular, can you please note that it is compared with the change in the objective between consecutive iterations?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org