Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3636#issuecomment-66178359
@Lewuathe Thanks for the PR! I added some inline comments. One more
general comment: When using subsampling (miniBatchFraction < 1.0), testing
against a convergenceTolerance can be dangerous because of the stochasticity.
It can be would be good to add a check at the beginning of optimization to see
if miniBatchFraction < 1.0 && convergenceTolerance > 0.0. If that is the case,
then we should print a warning.
Let me know when I should make another pass over the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
