Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3636#discussion_r21556478
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -142,7 +154,9 @@ object GradientDescent extends Logging {
* @param regParam - regularization parameter
* @param miniBatchFraction - fraction of the input data set that should
be used for
* one iteration of SGD. Default value 1.0.
- *
+ * @param convergenceTolerance - Minibatch iteration will end within
numIterations
--- End diff --
"will end within numIterations" --> "will end before numIterations"
(clearer, IMO)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
