Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3518#discussion_r21786759
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -458,6 +458,17 @@ private[spark] class TaskSetManager(
val startTime = clock.getTime()
// We rely on the DAGScheduler to catch non-serializable
closures and RDDs, so in here
// we assume the task can be serialized without exceptions.
+
+ // Check if serialization debugging is enabled
+ val debugSerialization: Boolean = sched.sc.getConf.
+ getBoolean("spark.serializer.debug", false)
+
+ // If enabled, print out the added JARs and files (as part of
the context)
--- End diff --
I do not believe that added JARs / files should have any bearing on whether
something serializes correctly (although they could impact _deserialization_).
Therefore, I don't think it makes sense to print this trace information via
this debug option.
Also: the user can easily trace this themselves by just logging
`sc.addedFiles` or `addedJars`, so I don't think that we need to have per-task
/ RDD logging of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
