Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4104#discussion_r23205557
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -82,6 +82,10 @@ object MimaExcludes {
                 // SPARK-5166 Spark SQL API stabilization
                 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Transformer.transform"),
                 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Estimator.fit")
    +          ) ++ Seq(
    +            // SPARK-5315 Spark Streaming Java API returns Scala DStream
    +            ProblemFilters.exclude[MissingMethodProblem](
    +              
"org.apache.spark.streaming.api.java.JavaDStreamLike.reduceByWindow")
    --- End diff --
    
    Hi Patrick, Mima test complains about this, so I added it here.
    
    Besides, what's your opinion about deprecating the old API or modifying it 
if this API is actually not correct? I'm not sure which is the good way, but 
@srowen suggested me to deprecate rather than modify.
    
    Thanks a lot :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to