Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/4104#discussion_r23365189
--- Diff: project/MimaExcludes.scala ---
@@ -82,6 +82,10 @@ object MimaExcludes {
// SPARK-5166 Spark SQL API stabilization
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Transformer.transform"),
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Estimator.fit")
+ ) ++ Seq(
+ // SPARK-5315 Spark Streaming Java API returns Scala DStream
+ ProblemFilters.exclude[MissingMethodProblem](
+
"org.apache.spark.streaming.api.java.JavaDStreamLike.reduceByWindow")
--- End diff --
This actually not a false positive. Since JavaDStreamLike is a trait, it
boils down to an abstract class. If someone has inherited their own class from
DStreamLike, and had a function reduceByKeyAndWindow with this signature (the
new one), his code will break as his code will now have to "override" the
method. So technically it is correctly. But I dont envision any one doing this,
so this binary compatibility break is fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
