Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4104#discussion_r23211173
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -82,6 +82,10 @@ object MimaExcludes {
                 // SPARK-5166 Spark SQL API stabilization
                 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Transformer.transform"),
                 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.ml.Estimator.fit")
    +          ) ++ Seq(
    +            // SPARK-5315 Spark Streaming Java API returns Scala DStream
    +            ProblemFilters.exclude[MissingMethodProblem](
    +              
"org.apache.spark.streaming.api.java.JavaDStreamLike.reduceByWindow")
    --- End diff --
    
    Hm, it doesn't make sense that Mima would complain since no methods have 
been removed. Can you double-check by trying a clean build without the 
exclusion? or else I am worried we're overlooking some obscure reason that this 
change still change the API, but I can't figure out why that could be. It could 
be a false positive in Mima.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to