maropu commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r314966093
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1279,8 +1409,26 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
(c, evPrim, evNull) => code"$evNull = true;"
case TimestampType =>
(c, evPrim, evNull) => code"$evPrim = (long)
${timestampToIntegerCode(c)};"
+ case DecimalType() if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ try {
+ $evPrim = $c.toJavaBigInteger().longValueExact();
+ } catch (ArithmeticException e) {
+ throw new ArithmeticException("Casting $c to Long causes
overflow");
Review comment:
It seems `longValueExact` throws an exception even when the non-overflow
case detected:
https://github.com/bpupadhyaya/openjdk-8/blob/master/jdk/src/share/classes/java/math/BigDecimal.java#L3088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
