maropu commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r314982581
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1279,8 +1409,26 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
(c, evPrim, evNull) => code"$evNull = true;"
case TimestampType =>
(c, evPrim, evNull) => code"$evPrim = (long)
${timestampToIntegerCode(c)};"
+ case DecimalType() if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ try {
+ $evPrim = $c.toJavaBigInteger().longValueExact();
+ } catch (ArithmeticException e) {
+ throw new ArithmeticException("Casting $c to Long causes
overflow");
+ }
+ """
case DecimalType() =>
(c, evPrim, evNull) => code"$evPrim = $c.toLong();"
+ case _: FloatType | _: DoubleType if failOnIntegerOverflow =>
+ (c, evPrim, evNull) =>
+ code"""
+ if ($c >= ${Long.MinValue}L && $c <= ${Long.MaxValue}L) {
Review comment:
Do we expect that this check matches the Nan case, too?
```
scala> sql("SET spark.sql.failOnIntegerOverFlow=true")
scala> sql("select cast(float('NaN') as long)").show
java.lang.ArithmeticException: Casting NaN to Long causes overflow.
at org.apache.spark.sql.types.FloatExactNumeric$.toLong(numerics.scala:137)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
