maropu commented on a change in pull request #25461: [SPARK-28741][SQL]Throw
exceptions when casting to integers causes overflow
URL: https://github.com/apache/spark/pull/25461#discussion_r314982376
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -494,7 +506,27 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
case DateType =>
buildCast[Int](_, d => null)
case TimestampType =>
- buildCast[Long](_, t => timestampToLong(t).toShort)
+ buildCast[Long](_, t => {
+ val longValue = timestampToLong(t)
+ if (!failOnIntegerOverflow || longValue == longValue.toShort) {
+ longValue.toShort
+ } else {
+ throw new ArithmeticException(s"Casting $t to Short causes
overflow.")
Review comment:
btw, this error is a kind of overflows? Is this not an out-of-range error as
pgSQL says so?
```
postgres=# select cast(float4(1e24) as bigint);
ERROR: bigint out of range
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
