HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener URL: https://github.com/apache/spark/pull/25943#discussion_r331834249
########## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ########## @@ -103,6 +104,81 @@ private[spark] class AppStatusListener( } } + // visible for tests + private[spark] def recoverLiveEntities(): Unit = { + if (!live) { Review comment: Hmm... I've found we don't recover AppStatusSource as it will not be passed when live == false. If possible I'd put assertion whether KVStore is empty when `live == true` then, but it depends on the possibility. If not, we may have to live with. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org