skonto commented on a change in pull request #25870: [SPARK-27936][K8S] Support 
python deps
URL: https://github.com/apache/spark/pull/25870#discussion_r344350662
 
 

 ##########
 File path: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala
 ##########
 @@ -125,16 +125,18 @@ private[spark] trait DepsTestsSuite { k8sSuite: 
KubernetesSuite =>
       .endSpec()
       .build()
 
-    kubernetesTestComponents
+    // try until the service from a previous test is deleted
+    Eventually.eventually(TIMEOUT, INTERVAL) (kubernetesTestComponents
 
 Review comment:
   Nope this is to address waiting for the elimination of the running service 
from a previous test. It is an easy retry until the previous service is removed 
and the new can succeed. If I remove this the new service may fail due to the 
previous one being terminated. The alternative is to block waiting for th eold 
service to be removed in the previous test.. I found this as an easy way not to 
block and succeed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to