skonto commented on a change in pull request #25870: [SPARK-27936][K8S] Support
python deps
URL: https://github.com/apache/spark/pull/25870#discussion_r344350662
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DepsTestsSuite.scala
##########
@@ -125,16 +125,18 @@ private[spark] trait DepsTestsSuite { k8sSuite:
KubernetesSuite =>
.endSpec()
.build()
- kubernetesTestComponents
+ // try until the service from a previous test is deleted
+ Eventually.eventually(TIMEOUT, INTERVAL) (kubernetesTestComponents
Review comment:
Nope this is to address waiting for the elimination of the running service
from a previous test. In this suite I have two tests that use Ceph-nano and for
each test I start the service from scratch so all tests start from a clean
state.
`Eventually` provides an easy retry mechanism until the previous service is
removed and the new can succeed. If I remove `eventually` the new service may
fail due to the previous one being terminated. The alternative is to block and
wait for the old service to be removed when a tests finished and deletes its
resources.. I found `eventually` being an easy way not to block and succeed.
Check next:
```
Test1 {
Allocate resources
Delete resources // <- K8s client delte calls dont block
}
Test2 {
Allocate resources
Delete resources
}
```
Setting ```eventually(Allocate resources)``` solves this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
