skonto commented on a change in pull request #25870: [SPARK-27936][K8S] Support
python deps
URL: https://github.com/apache/spark/pull/25870#discussion_r344354367
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
##########
@@ -259,12 +259,19 @@ private[spark] object KubernetesUtils extends Logging {
isLocalDependency(Utils.resolveURI(resource))
}
- def renameMainAppResource(resource: String, conf: SparkConf): String = {
+ def renameMainAppResource(
+ resource: String,
+ conf: Option[SparkConf] = None,
+ isJava: Boolean = true): String = {
Review comment:
@dongjoon-hyun ok sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
