s2moon98 commented on code in PR #4838:
URL: https://github.com/apache/zeppelin/pull/4838#discussion_r1817716660
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:
##########
@@ -587,10 +589,18 @@ public Connection getConnection(InterpreterContext
context)
}
private void validateConnectionUrl(String url) {
- if (containsIgnoreCase(url, ALLOW_LOAD_LOCAL_IN_FILE_NAME) ||
- containsIgnoreCase(url, AUTO_DESERIALIZE) ||
- containsIgnoreCase(url, ALLOW_LOCAL_IN_FILE_NAME) ||
- containsIgnoreCase(url, ALLOW_URL_IN_LOCAL_IN_FILE_NAME)) {
+ String decodedUrl;
+ try {
+ decodedUrl = URLDecoder.decode(url, "UTF-8");
Review Comment:
oh, I didn't noticed that `decode(String s, Charser charset)` doesn't exist
in JAVA8. Thank you for letting me know.
Then, if https://github.com/apache/zeppelin/pull/4882 merged into master, I
will request approval again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
