Reamer commented on code in PR #4838:
URL: https://github.com/apache/zeppelin/pull/4838#discussion_r1830521536
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:
##########
@@ -587,10 +590,13 @@ public Connection getConnection(InterpreterContext
context)
}
private void validateConnectionUrl(String url) {
- if (containsIgnoreCase(url, ALLOW_LOAD_LOCAL_IN_FILE_NAME) ||
- containsIgnoreCase(url, AUTO_DESERIALIZE) ||
- containsIgnoreCase(url, ALLOW_LOCAL_IN_FILE_NAME) ||
- containsIgnoreCase(url, ALLOW_URL_IN_LOCAL_IN_FILE_NAME)) {
+ String decodedUrl;
+ decodedUrl = URLDecoder.decode(url, StandardCharsets.UTF_8);
+
+ if (containsIgnoreCase(decodedUrl, ALLOW_LOAD_LOCAL_IN_FILE_NAME) ||
Review Comment:
Wrong indentation
```suggestion
if (containsIgnoreCase(decodedUrl, ALLOW_LOAD_LOCAL_IN_FILE_NAME) ||
```
##########
jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java:
##########
@@ -42,6 +42,9 @@
import org.slf4j.LoggerFactory;
import java.io.IOException;
+import java.io.UnsupportedEncodingException;
Review Comment:
Unnecessary import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
