pan3793 commented on PR #4838: URL: https://github.com/apache/zeppelin/pull/4838#issuecomment-2440454684
some thoughts: - PR title and desc are misleading, the key change of this PR is, validating the decoded URL instead of the encoded URL - if the decoded URL is an illegal UTF-8 sequence, the new code just skips validation, I'm not sure this is the correct behavior. from the security perspective, we should fail immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
