tbonelee commented on code in PR #5072:
URL: https://github.com/apache/zeppelin/pull/5072#discussion_r2347203697
##########
zeppelin-web-angular/package.json:
##########
@@ -12,10 +12,16 @@
"build-project:sdk": " ng build --project zeppelin-sdk",
"build-project:vis": " ng build --project zeppelin-visualization",
"build-project:helium": "ng build --project zeppelin-helium",
- "test": "ng test",
"lint": "ng lint && tslint -p tslint-rules/tsconfig.json && prettier
--check \"**/*.{ts,js,json,css,html}\"",
"lint:fix": "ng lint --fix && tslint --fix -p tslint-rules/tsconfig.json
&& prettier --write \"**/*.{ts,js,json,css,html}\"",
- "e2e": "ng e2e"
+ "e2e": "playwright test",
+ "e2e:fast": "playwright test --project=chromium",
+ "e2e:ui": "playwright test --ui",
+ "e2e:headed": "playwright test --headed",
+ "e2e:debug": "playwright test --debug",
+ "e2e:report": "playwright show-report",
+ "e2e:ci": "export CI=true && playwright test",
+ "e2e:codegen": "npm run start || playwright codegen http://localhost:4200";
Review Comment:
If both commands must succeed to proceed, replace `||` with `&&` or `;`.
With `||`, the second command runs only if the first fails.
Also, if the first command succeeds, it blocks, so the second won't start.
It's better to run them in parrallel and launch the second only after the first
is up (e.g., using the `start-server-and-test` package).
##########
zeppelin-web-angular/package.json:
##########
@@ -104,4 +103,4 @@
"pre-commit": "lint-staged"
}
}
-}
+}
Review Comment:
New line is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
