Henry-Hong commented on code in PR #5072:
URL: https://github.com/apache/zeppelin/pull/5072#discussion_r2356120528
##########
zeppelin-web-angular/package.json:
##########
@@ -12,10 +12,16 @@
"build-project:sdk": " ng build --project zeppelin-sdk",
"build-project:vis": " ng build --project zeppelin-visualization",
"build-project:helium": "ng build --project zeppelin-helium",
- "test": "ng test",
"lint": "ng lint && tslint -p tslint-rules/tsconfig.json && prettier
--check \"**/*.{ts,js,json,css,html}\"",
"lint:fix": "ng lint --fix && tslint --fix -p tslint-rules/tsconfig.json
&& prettier --write \"**/*.{ts,js,json,css,html}\"",
- "e2e": "ng e2e"
+ "e2e": "playwright test",
+ "e2e:fast": "playwright test --project=chromium",
+ "e2e:ui": "playwright test --ui",
+ "e2e:headed": "playwright test --headed",
+ "e2e:debug": "playwright test --debug",
+ "e2e:report": "playwright show-report",
+ "e2e:ci": "export CI=true && playwright test",
+ "e2e:codegen": "npm run start || playwright codegen http://localhost:4200";
Review Comment:
Maybe you can try '&' operator.
But 'concurrently' would be also great option since '&' doesn't support
cross-platform. (& is unix shell command)
Or we can just assume that user has already run angular dev server through
'npm run start' in another shell. So we can do just only `"e2e:codegen" :
"playwright codegen http://localhost:4200"` without any operators and
additional dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
