tbonelee commented on PR #5080:
URL: https://github.com/apache/zeppelin/pull/5080#issuecomment-3347541782
Thanks for the review!
I've habitually put comments inside the condition blocks because it keeps
things consistent with a following `else if` block.
Instead of,
```typescript
// Comment for if block
if (...) {
...
// Comment for if else block
} else if (...) {
...
}
```
I've been doing:
```typescript
if (...) {
// Comment for if block
...
} else if (...) {
// Comment for if else block
}
```
But while writing the comments and testing in my IDE, I realized the pattern
below also works well and it plays nicely with Prettier 😂
```typescript
// Comment for if block
if (...) {
...
}
// Comment for if else block
else if (...) {
}
```
Anyway, there are no standalone `else` branches here, so I'm fine placing
the comments outside the blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
