tbonelee commented on code in PR #5080: URL: https://github.com/apache/zeppelin/pull/5080#discussion_r2388183188
########## zeppelin-web-angular/src/app/key-binding/key-binder.ts: ########## @@ -0,0 +1,73 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import { ElementRef } from '@angular/core'; +import { editor as MonacoEditor } from 'monaco-editor'; +import { from, Subject } from 'rxjs'; +import { map, mergeMap, takeUntil } from 'rxjs/operators'; + +import { ShortcutService } from '@zeppelin/services'; +import * as _ from 'lodash'; Review Comment: Good point. I switched lodash to named imports for consistency. I’m keeping castArray/isNil, and I use chain when we benefit from lazy evaluation to avoid intermediate arrays. Previously, lodash’s map conflicted with RxJS’s map, which blocked named imports. Since stand-alone _.map() is equivalent to native array .map() for our use, I replaced it with the native method. That removes the collision, lets us use named imports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
