tbonelee commented on PR #5080: URL: https://github.com/apache/zeppelin/pull/5080#issuecomment-3352849652
I've been trying to add E2E tests for key bindings, but there's an issue that scenarios involving 'creating test note' harder. If browser 'A' opens `Create New Note` modal to create new test note and browser 'B' actually creates the note, a `NOTES_INFO` message arrives, `this.cdr.markForCheck()` is called, and the modal on browser 'A' is closed. As a result, 'A' fails to click the 'Create' button. I'll create an issue for this and plan to add the keybinding E2E tests after it's fixed. Tests that rely on creating a fresh note will likely hit the same problem, so we might have to address this first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
