RichieB;501149 Wrote:
> Andy seems to agree that iTunNorm should only be added to RVA and not to
> ReplayGain: https://bugs.slimdevices.com/show_bug.cgi?id=6890#c21
> (I can confirm that iTunes ignores TXXX tags, but does add SoundCheck
> adjustments to RVA values.)
>
> However, that's not how it is implemented in
> http://svn.slimdevices.com/slim/7.5/trunk/server/Slim/Utils/SoundCheck.pm?view=markup
> starting at line 43.
Please read the code correctly, starting in Slim::Formats::MP3. The
iTunNorm logic is working as intended. As stated several places before,
it is only used if you don't have a TXXX REPLAYGAIN_TRACK_GAIN tag. And
if this is the case, the value is added to any RVA value.
The comment in the code explains this:
Code:
--------------------
# Logic used here is:
# If there is an iTunNORM tag and an RVA tag:
# Gain values are added together
# If there is no iTunNORM tag, the value used is RVA if
available
# See bug 6890 for more info
--------------------
--
andyg
------------------------------------------------------------------------
andyg's Profile: http://forums.slimdevices.com/member.php?userid=3292
View this thread: http://forums.slimdevices.com/showthread.php?t=73291
_______________________________________________
ripping mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/ripping
