Valery Masiutsin wrote:
Hello,guys !
Here's more patches.
1.doc_Makefile_am.diff - simple oneliner fixes make clean in docs.
2.src_apache-2_Makefile_am.diff
Fixes includes, otherwise macros expansion breakes, ApacheRequest_upload is a
good example, it compiles fine but you are getting undefined symbol
once you are calling it.
N.B. probably mod_rivet for apache-1 in trunk suffers this as well,
need to check.
Would you tell me more about this? Your patch is doing this change
-INCLUDES = [EMAIL PROTECTED]@ [EMAIL PROTECTED]@
+INCLUDES = -I"." [EMAIL PROTECTED]@ [EMAIL PROTECTED]@
I can see the -I . switch during the compilation process for every file (I
presume this is a byproduct of automake)
I've deleted Rivet_ParseUri function - dont see much sense in its
existence at this moment - it's broken anyway.
Added ap_chdir_file function implementation for apache2 - did not
reinvent the wheel, and grabbed it from mod_ruby, we can rewrite it if
ap_chdir_file was simply commented out (why?). In fact I noticed
yesterday that
some pages that had nested templates in them were broken.
Printing the output of 'pwd' showed that templates were stuck to the
documentRoot
it needs so, or include it as it is, with clearly marked credits.
I don't see why we should keep it.
5.src_apache-2_apache_request_h.diff
Changed prototype of ApacheRequest_tmpfile function to return
apr_file_t instead of FILE, also modified ApacheUpload structure - did
same change.
ok
6. src_apache-2_apache_request_c.diff
Completely rewrote ApacheRequest_tmpfile function using apr functions,
questionable part is a filename generation for tmp files.
Next some changes to ApacheRequest_parse_multipart (enough to make it work).
Ideas were taken from apache module book.
BB? (Bucket Brigade) Are you already doing it?
7.src_apache-2_TclWebapache_c.diff
Rewrote TclWeb_UploadSave function - i did not found the way to get
fileno() handler from apr_file_t() so i replaced all stuff with
single apr_file_copy() function, which just copies file from tmp to
target one, probably need to add here checks for
maxsize and UploadDirectory.
Because of changes ApacheUpload* stuff i had to do some typecasting on
functions in TclWebapache.c - just to repair the build, they are not
usable at the moment.
With all this i was able to perform file upload using
doc/examples/upload* pages.
My intension is to leave function interface in TclWebapache as it is
for apache2, but all internals probably will be rewritten using apr_*
functions equivalents. Apache/apr community insists that they are
cross-platform safe, may be they right, but anyway it will simplify
things a good bit.
All comments are welcome.
Regards Valery.
I'm adding a small patch for a macro in configure.ac (a simple message
to be printed for the apxs program found)
I've done a fresh checkout to try the build system (as it would be now for
a newcomer) and found out that lib_libexec in src/Makefile.am is expanded
into '/usr/lib /rivet' (please note the space char between '/usr/lib'
and '/rivet').
This breaks the installation of librivet, but it seems that I'm the only
person
who is having this problem (I can handle it only hacking the Makefile
by hand, a humbling experience)
-- Massimo
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
