Al Le wrote:
The problem being solved by this patch is IMO that the user gets what he would expect, i.e. the principle of least astonishment. If I've loaded a theme and have not changed any theme related settings I'd then expect that this theme would be pre-selected when I call "Browse Themes." If at least one theme related setting has been modified then we can add an asterisk or do something else (some ways have been already proposed in this thread).
Except "file browsers" in Rockbox don't work like this, and the main file browser still won't even after this change. Is "least astonishment" when behaviours learned elsewhere persist into other areas that present themselves as the same sort of device or interface, or when various screens all calling themselves browsers seem to do things in different ways from each other (which is what you're suggesting here)?
These proposals are mostly trying to create a situation where a user has to understand lower-level aspects of what themes are just to know why a screen is sometimes staying one way, and other times changing, and possibly some settings will cause it to change sometimes and other times not cause it to change, and so forth.