Again, please cite your sources Alex... I'm pretty sure you were the one who suggested this vtable system in the first place, for at least some parts of the FreeLoader code anyways, because I didn't write it. But it does have some usefulness in places such as the UI code where, depending on the platform, it does take a different code path, and multiple code paths are valid options to be compiled in and parsed at runtime depending on the .ini file.
In any case, please stop adding useless comments like this unless you intend to bring up the original points of objection along with it. A simple "I agree with the proposed change" would have sufficed here, and I'm tired of going the rounds with you over conversations that never took place. -----Original Message----- From: ros-dev-boun...@reactos.org [mailto:ros-dev-boun...@reactos.org] On Behalf Of Alex Ionescu Sent: Sunday, June 19, 2011 7:27 AM To: ReactOS Development List Subject: Re: [ros-dev] freeldr I wrote this exact same request 3 years ago and Brian said no :) Best regards, Alex Ionescu On Sun, Jun 19, 2011 at 9:02 AM, Timo Kreuzer <timo.kreu...@web.de> wrote: > Hi, > > I'd like to change the Vtbl based architecture of freeldr into a normal > function call system. > Currently we have stuff like > > #define MachHwDetect() MachVtbl.HwDetect() > MachVtbl.HwDetect = PcHwDetect; > > This is IHO simply useless, since these functions don't change. I suggest > simply renaming PcHwDetect to MachHwDetect and do that will all of those and > get rid of the MachVtbl. > > Any objections? > > Regards, > Timo > > > > _______________________________________________ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev _______________________________________________ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
