Hello Everyone.

I've attached at patch for consideration.

Main purpose of patch:
----------------------
* This patch allows the user to decide if RG will attach suffixes such as 
"(copied)", "(recorded)", "(split), etc. to segment labels.

How to use feature:
-------------------
* From Settings->Configure Rosegarden...

* Goto General->Behavior (this is the front page of the dialog on my system.)

* Select or de-select the "Append suffixes to segment labels" checkbox.  This 
is set to "true" by default to mimic standard RG behavior.

* Select "OK."
 
Other goals of patch:
---------------------
* Simplify adding suffixes to segment label.  This makes the code easier to 
read.

* Makes how RG adds label suffixes consistent throughout application.  Current 
code has each function implement error checking and decision making such as: 
Does the suffix--like "(copied)"--already appear in the label? Labeling code 
was not consistently applied in the code, I found several implementations of 
the code I believe was intended to give the same result.

* Updated Split on Silence feature to add "(part %1)" instead of "(part)" for 
SegmentAutoSplitCommand and "(autosplit %1)" for AudioSegmentAutoSplitCommand.  
This was a morphing of how the to commands did autosplitting.

Known Issues:
-------------
* Translations need updated.  In the German translation, I found about 10 
messages that need updated.

Questions:
----------
* I don't know if I implemented the best way to read Rg configurations in 
base/Segments.cpp.  I had to include <kapplication.h> and <kconfig> to 
Segment.cpp.  Is there a more elegant method to get at the configuration values.

* If this patch is added, should I go and edit the translations.  Other than 
the "(part %1)" label I can easily discern what needs to be modified in each 
file.  I can even make an intelligent guess from existing messages how to 
correct the "(part %1)" autosplit messages.  I didn't want to step on anyones 
toes concerning this--the translators have done a lot of work and I didn't want 
to interfere with that process.

...

I'm open for comments and suggestions.

Sincerely,
Julie S.



      

Attachment: labelsuffix-patch
Description: Binary data

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to