Dear Michael,
Boy, I didn't intend to stir the pot so much. I guess I found that cow pasture
you were talking about.
I've read both of your posts. Good advice on the translation stuff. I thought
that leaving it alone might be best.
QT/KDE/OS-X/--That is really all beyond me. I know QT works on several
platforms. KDE in a Linux thing as far as I know. So I can see limiting any
extra KDE code since portability is an issue. I can also see monopolizing on
QT--like Qsettings and tr. But, RG creators intended an even more portable
base. So, I would want to respect that.
Now I understand the translation page on the RG site that talks about design
issues and internal storing of content. It sounds like we are dealing with an
original intent issue and being true to the intents of the author.
You said:
> 1) Pull the bool deciding logic into gui/ in whatever way seems the
> most elegant and least redundant, and pass a new parameter to
> Segment::setLabelPrefix() to let it know the answer to the user's GUI
> config question
As far as checking configuration files is concerned, We can fix that, too,
using your approach. But, we would need to write a function that checks the
status and returns a bool. We could pass that value as a parameter as you
suggested. But, I think that would make setLabelSuffix clumsy in practice and
nonfocused. If we checked the status and know the answer, why would we call
seLabelSuffix and pass it a bool false, knowing the outcome of the call to
setLAbelSuffix is to do nothing.
I guess I'm arguing that if we pull the status check out from setLabelSuffix,
we should use the results of the call to the check the status to decide if even
to call setSuffixLabel.
So, we could leave the checking of adding duplicate suffixes to the original
setLabelSuffix command and do a call to check the status
"isAppendLabelChecked()" (or some other named function). Then check the
results before calling setLabelSuffix
So, a sample fragment in a command would look like:
if (isAppendLabelChecked()) {
new_segment->setLabelSuffix(qstrtostr(i18n("(copied")));
}
Where to define isAppendLabelChecked() is a good question since it needs to be
available to multiple areas of RG code. Maybe in the src/misc directory.
...
You said:
> 2) Bothering with any of this complicated what if logic
> to preserve old behavior that everyone has always thought
> was cheese anyway?
This code was an attempt to address that. Yes I think label suffixes are
cheese. I also think people should be careful when editing--specially in bulk,
but I think they serve a purpose at time. I think removing the suffixes
completely might be a bit unwise. At times they can be helpful, but usually
they are a nuisance.
It as an attempt to add features without taking away intent of the author, just
like the whole KDE and QT in base class stuff--just a smaller scale courtesy.
Well, those are my thoughts.
Sincerely,
Julie S.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
