> Now, having written all that, I'll go actually take a look at the patch, > and I'll get back to you with any further thoughts.
Bah. My post hasn't arrived yet, so I'll just re-reply to the original message. Having looked at the patch briefly, it seems like having this code in Segment is elegant in terms of minimizing redundancy, and I'm not seeing a tidy way to tweak it to avoid the whole issue. Looks like a tweak would involve passing in a bool and redundant code in several places to get a value for that bool, all to accomplish something of dubious value in the first place. So the biggest question is which is more dubious here. 1) Continuing to exclude QT from base/ in this brave new world of (almost completely) vaporware Rosegarden 2.0 for QT/KDE4? 2) Bothering with any of this complicated what if logic to preserve old behavior that everyone has always thought was cheese anyway? Depending on that answer, possible solutions are: 1) Pull the bool deciding logic into gui/ in whatever way seems the most elegant and least redundant, and pass a new parameter to Segment::setLabelPrefix() to let it know the answer to the user's GUI config question 2) Commit the patch. Who really cares at this late date about keeping QT out of base/ anyway? (Although if we make that argument, it follows to get rid of all the qstrtostr() whatever hackery we have bloody everywhere in this thing already to accommodate that original design parameter, and it wouldn't be very clean just to let one exception in half-assed without refactoring all of base to just use bloody QString already) 3) Forget about the GUI configuration what if jibbledefruckis and just decide to eliminate the stupid suffixes entirely anyway. 4) Proposition 933B 5) Eat more Cheese Whiz. I don't know. Big proclamations like this one really need someone from on higher than I am in the scheme of things. We don't have a real official leader, but Chris writes better code in his sleep than I write at my height of achievement, so let's see if we can't lure him into this, shall we? (Proposition 933B is the one where we vote to pay me a salary of $50,000 USD per year.) Aw crap. Gotta run anyway. -- D. Michael McIntyre ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
