"Stephen R. van den Berg" <[email protected]> wrote:
> That basically sums it up. Multiple changes in core parts => more chance
> of conflict with upstream updates => more long term maintenance work.
Ok, although in this particular case it wouldn't have been multiple
changes:
Index: etc/modules/RXML.pmod/module.pmod
===================================================================
RCS file: /cvs/Roxen/5.0/server/etc/modules/RXML.pmod/module.pmod,v
retrieving revision 1.412
retrieving revision 1.413
diff -u -r1.412 -r1.413
--- etc/modules/RXML.pmod/module.pmod 20 Apr 2010 13:09:55 -0000 1.412
+++ etc/modules/RXML.pmod/module.pmod 27 Apr 2010 20:37:29 -0000 1.413
@@ -2,7 +2,7 @@
//
// Created 1999-07-30 by Martin Stjernholm.
//
-// $Id: module.pmod,v 1.412 2010/04/20 13:09:55 mast Exp $
+// $Id: module.pmod,v 1.413 2010/04/27 20:37:29 mast Exp $
// Kludge: Must use "RXML.refs" somewhere for the whole module to be
// loaded correctly.
@@ -1972,6 +1972,9 @@
if (check_nil)
res = filter (res, lambda (string var) {
mixed val = vars[var];
+ if (objectp (val) && ([object] val)->rxml_var_eval)
+ val = ([object(Value)] val)->rxml_var_eval (
+ this, var, scope_name, 0);
return val != nil && !zero_type (val);
});
return res;