On Aug 6, 2013, at 9:55 AM, Per Øyvind Karlsen wrote:
>
> Meanwhile "Write a test case." is the only sane response to preventing
> regressions.
> Yes, I've included a simple regression test in the patch included which fixes
> the regression as well.
>
And the regression test case is visibly syntactically incorrect:
--- rpm-5.4.12/tests/Makefile.am.rpmluaext~ 2013-08-06 15:52:53.941594400
+0200
+++ rpm-5.4.12/tests/Makefile.am 2013-08-06 15:52:42.851402687 +0200
@@ -974,6 +974,7 @@ check-convert:
check-lua:
@echo "=== $@ ==="
@-${rpm} -E '%{lua:print("--> lua: Hard Rocks!")}'
+ @-${rpm} -E '%{lua:print(rpm.expand("--> lua: rpm macro expansion
works on rpm %{_rpmversion}!"))
@-${rpm} -e lua-test
@-${rpm} -U lua-test/lua-test-*.noarch.rpm
@-${rpm} -e lua-test
Did you even bother to try-and-see before wasting my time?!?
73 de Jeff
