Hi, Sorry for the late reply: I was on holidays. Sure, go ahead with rpmlog and indentation changes, if it doesn't bother you to do this! I will then start concentrating on rest of the stuff: need to do some more thinking on it to begin with.
Best Regards, Elena. -----Original Message----- From: Panu Matilainen [mailto:pmati...@laiskiainen.org] Sent: Thursday, November 01, 2012 10:22 AM To: Reshetova, Elena Cc: rpm-maint@lists.rpm.org Subject: Re: [Rpm-maint] [PATCH 1/2] Extending rpm plugin interface, part 1 On 10/26/2012 12:56 PM, Reshetova, Elena wrote: > Hi, > > Please find the corrected patch in the attachment. > I really spend quite some time fighting indentation :( , but let's > hope it succeeded now (I am not that sure since it so much changing > when I open it with different editors/settings). > I was trying to use only soft tabs: 4 spaces, but in places where I > had to integrated in existing code it behaves unpredictable because of > hard tabs that I think in some places aren't of same size (but maybe > this is my inability to use editors). It's much better now, thanks. There are a couple of misindentations still but I can just as well tweak those while applying, and its not as if the whole codebase is perfectly indented, I just want new things to land in a shape that doesn't need immediate whitespace "fixes" as they mask away real changes from eg "git blame". I dunno what editor(s) you use, vi(m) is what I live and breath by - for sure its arcane but at least it doesn't mess with the formatting you choose :) The only setting I have wrt C in ~/.vimrc is "autocmd BufRead,BufNewFile *.[chi] set sw=4" Apart from indentation-trivia, there's just one issue that I see: + if (!plugins || rstreq(plugins, "")) { + rpmlog(RPMLOG_INFO, _("Failed to expand %%__transaction_plugins macro\n")); + return rc; + } This still causes superfluous/bogus messages to be emitted on what I consider to be the default case of no plugins being configured. I'd rather just remove the rpmlog() line from there for now, or at least change it to RPMLOG_DEBUG so it wont show up on regular uses like 'rpm -Uvh'. If you dont mind me doing a couple of indentation fixes and the rpmlog() change, I'll just go ahead and commit it with those tweaks. FWIW I'm just about to branch off for rpm-4.11 (sooner than I originally planned but...), the plugin changes will at least initially go to master only to give us time and freedom to fiddle with the details. - Panu -
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
