pmatilai commented on this pull request.
> + /* add results to requires of the srpm */
+ argvSplit(&output, getStringBuf(sb_stdout), "\n\r");
+ outc = argvCount(output);
+
+ if (!outc) {
+ rc = RPMRC_OK;
+ goto exit;
+ }
+
+ for (int i = 0; i < outc; i++) {
+ parseRCPOT(spec, spec->sourcePackage, output[i], RPMTAG_REQUIRENAME, 0,
0, addReqProvPkg, NULL);
+ }
+
+ rpmdsPutToHeader(*packageDependencies(spec->sourcePackage,
RPMTAG_REQUIRENAME), spec->sourcePackage->header);
+
+ parseRCPOT(spec, spec->sourcePackage, "rpmlib(DynamicBuildRequires) =
4.15.0-1", RPMTAG_PROVIDENAME, 0, RPMSENSE_FIND_PROVIDES | RPMSENSE_RPMLIB,
addReqProvPkg, NULL);
There are some seriously overlong lines here, both parseRCPOT() calls and the
rpmdsPutToHeader(). Please adjust to 80 character line-length.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-235955768_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
