pmatilai commented on this pull request.
> goto exit;
+ if (what & RPMBUILD_BUILDREQUIRES)
+ rc = doBuildRequires(spec, test);
+ if ((what & RPMBUILD_CHECKBUILDREQUIRES) &&
+ (rc == RPMRC_MISSINGBUILDREQUIRES))
+ rc = doCheckBuildRequires(ts, spec, test);
The condition and if-block are on the same indentation level here, please fix.
This whole doScript() related if-section is quite a mess to begin with and
violates rpm general style, so an alternative to indenting the conditional is
indenting the if-block deeper, as is done with the goto exit's below.
Readability is far more important than following style to the letter, and
consistency with surroundings helps readability too.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-235965472
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
