pmatilai commented on this pull request.
> @@ -273,20 +287,6 @@ static struct poptOption optionsTable[] = {
POPT_TABLEEND
};
-static int checkSpec(rpmts ts, rpmSpec spec)
-{
- int rc;
- rpmps ps = rpmSpecCheckDeps(ts, spec);
-
- if (ps) {
- rpmlog(RPMLOG_ERR, _("Failed build dependencies:\n"));
- rpmpsPrint(NULL, ps);
- }
- rc = (ps != NULL);
- rpmpsFree(ps);
- return rc;
-}
-
Please split this move of build-requires checking into librpmbuild with a new
special return code to a separate commit. It makes for a nice independent and
logical step that serves as a regression checkpoint against existing behavior
and also makes the final commit of the actual new feature more contained.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-235967922_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
