pmatilai commented on this pull request.
> @@ -8,13 +8,99 @@
#include "build/rpmbuild_internal.h"
#include "debug.h"
+static int addLinesFromFile(rpmSpec spec, const char * const fn, rpmTagVal tag)
+{
+ int nlines = 0;
+ int flags = STRIP_COMMENTS | STRIP_TRAILINGSPACE;
+ ARGV_t argv = NULL;
+
+ int terminate = rpmExpandNumeric(tag == RPMTAG_SOURCE
+ ? "%{?_empty_sourcelist_terminate_build}"
+ : "%{?_empyy_patchlist_terminate_build}");
The patchlist macro has a typo (empyy vs empty). However the bigger thing is
that I don't think these should be configurable. With %files, an empty %files
section is special as that controls whether the package gets built at all, but
for source and patch lists, I don't see any reason to allow them to be empty.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1043#pullrequestreview-352814509_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
