pmatilai commented on this pull request.
> + rpmlog(RPMLOG_ERR, _("line %d: Bad option %s: %s\n"),
+ spec->lineNum,
+ poptBadOption(optCon, POPT_BADOPTION_NOALIAS),
+ spec->line);
+ goto exit;
+ }
+
+ lst = argvNew();
+
+ for (arg = 1; arg < argc; arg++) {
+ if (rstreq(argv[arg], "-f")) {
+
+ if (!argv[arg+1]) {
+ rpmlog(RPMLOG_ERR,
+ _("line %d: \"%%%s -f\" requires an argument.\n"),
+ spec->lineNum, name);
We have popt for option and argument parsing, use it. Manually testing for
options and their arguments doesn't cut it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1043#pullrequestreview-352818327_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
