pmatilai commented on this pull request.


> @@ -8,13 +8,99 @@
 #include "build/rpmbuild_internal.h"
 #include "debug.h"
 
+static int addLinesFromFile(rpmSpec spec, const char * const fn, rpmTagVal tag)
+{
+    int nlines = 0;
+    int flags = STRIP_COMMENTS | STRIP_TRAILINGSPACE;
+    ARGV_t argv = NULL;
+
+    int terminate = rpmExpandNumeric(tag == RPMTAG_SOURCE
+                                    ? "%{?_empty_sourcelist_terminate_build}"
+                                    : "%{?_empyy_patchlist_terminate_build}");

Fair enough I guess. But if we consider it valid then let it always be valid. 
We have way, way too many of these fiddly configurables as it is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1043#discussion_r374710238
_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to