@pmatilai commented on this pull request.
> @@ -245,6 +245,10 @@ Supplements: (%{name} = %{version}-%{release} and
> langpacks-%{1})\
# Is ignored when SOURCE_DATE_EPOCH is not set.
%clamp_mtime_to_source_date_epoch 0
+# If true, make sure that timestamps in built rpms
+# are not later than the build time of the package.
+%clamp_mtime_to_buildtime 0
This means we now have two independent knobs for the same thing, and both
cannot be right.
I'd rather have something like `%clamp_mtime` macro that accepts
none/buildtime/source_date_epoch as possible values.
`%clamp_mtime_to_source_date_epoch` can then be deprecated and routed to the
new macro for now, for backwards compatibility.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2944#pullrequestreview-1916204585
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2944/review/1916204...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
