@keszybz commented on this pull request.
> @@ -245,6 +245,10 @@ Supplements: (%{name} = %{version}-%{release} and
> langpacks-%{1})\
# Is ignored when SOURCE_DATE_EPOCH is not set.
%clamp_mtime_to_source_date_epoch 0
+# If true, make sure that timestamps in built rpms
+# are not later than the build time of the package.
+%clamp_mtime_to_buildtime 0
I think this pull request is very reasonable. Though, as @pmatilai said, a
"`%clamp_mtime` macro that accepts `none`/`buildtime`/`source_date_epoch`"
would be nicer. It's more forward-looking, because maybe there will be another
idea in the future and then we can just another value. And because there's just
one setting, there can be no question of precedence between the different
options.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2944#discussion_r1513986380
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2944/review/1918997...@github.com>_______________________________________________
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
