https://bugzilla.rpmfusion.org/show_bug.cgi?id=2819
--- Comment #2 from Marco Casaroli <[email protected]> 2013-05-31 19:35:50 CEST --- Hello, thank you for the comments. The issues you pointed are checked and fixed. Please review the spec file again. You say that I need to explicit each file in %files? Thank you (In reply to comment #1) > Hi Marco. > I'm not a sponsor so I can just do some comments. ;) > > - You don't need rm -rf $RPM_BUILD_ROOT anymore if your package is destined to > a recent Fedora release and a RHEL/CentOS 6. > > - > >mkdir $RPM_BUILD_ROOT > >mkdir $RPM_BUILD_ROOT/usr > >mkdir $RPM_BUILD_ROOT/usr/bin > >... > > Too complex, a right option of the 'mkdir' command is sufficient ;) > > - Try to use more properly all macro available; for example: > > $RPM_BUILD_ROOT/usr/share/%{name}/%{version} > > becomes > > $RPM_BUILD_ROOT/%{_datadir}/%{name}/%{version} > > See http://fedoraproject.org/wiki/Packaging:RPMMacros > > - In my opinion, all files must be explicated better in the %files section. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.
