Yeah I definitely agree that this should change. It's actually bitten me a couple of times where I, when writing my initial tests, would forget to write the XML view, but the test still passed because it rendered the HTML template. Bad Rails! Bad!
Would love to see this implemented to be more strict. --Jeremy On Aug 8, 10:19 pm, Yehuda Katz <wyc...@gmail.com> wrote: > In Rails 2.x, if you have an XML template, and try to render a template > that does not have an XML version, but does have an HTML version, it > will be rendered. XML and HTML are just examples; this is true for any > two mime types. > > Is this behavior important? First of all, I'm not sure this is the right > behavior, since it's possible to be explicit about the format you wish > to use and rendering a template from a different MIME seems likely to be > a mistake. Second of all, it requires us to widen our search criteria > when looking for subsidiary templates (like partials), and prevents us > from efficiently caching the template for a given format (instead, we > need to cache the template for a given Array of formats, which is much > less efficient). > > I also think that restricting subsidiary templates would be consistent > with other (non-breaking) fixes we've done to ensure that layouts match > the MIME type of the template they are wrapping (which allowed us to > eliminate the exempt_from_layout hacks). > > Thanks for your attention, > > -- Yehuda --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
