Oops. Hit sent before completing the email. Anyway, I was thinking it may be a good idea to take keyword arguments to precise control the amount of indentation/tab vs space, etc to override the auto-detection, in the rare cases where it is needed.
For example, when processing an indented markdown code block (triple backtick), it is a good idea to use the indentation level of the backtick instead of looking at the content. Some times there may be intentional indentation inside the code block that is meant to be part of the content (e.g. ASCII art and other kind of diagrams). On Sun, Jun 9, 2019 at 7:22 PM Godfrey Chan <godfrey...@gmail.com> wrote: > +1 to what Matthew said > > If we are switching the use case of the method to stripping indentation, I > wonder if we should just call it `outdent`. > > By default it could auto detect the indentation like it does now, but > there were a couple of times I was processing strings with known > indentation that I want to remove, but for some reason the auto detection > wasn’t quite right. > > On Sun, Jun 9, 2019 at 2:03 AM Matthew Draper <matt...@trebex.net> wrote: > >> >> >> > The squiggly-heredoc operator can't be applied to an already existing >> string. That is the only case were you still need strip_heredoc, so unless >> we add a way to strip heredocs from an already existent string object to >> Ruby we can't deprecated it. >> >> How about we rename it to something like `strip_indent`? >> >> As you should no longer be using it on a heredoc, the current name isn’t >> a great fit. >> >> And then we can deprecate the old name, with a suggestion to use <<~ if >> possible, or strip_indent if not. >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to rubyonrails-core+unsubscr...@googlegroups.com. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> Visit this group at https://groups.google.com/group/rubyonrails-core. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/rubyonrails-core/5B924D0D-9CD2-41BD-8485-5A07ED807022%40trebex.net >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-core@googlegroups.com. Visit this group at https://groups.google.com/group/rubyonrails-core. To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/CAC%3DHGusZ%3D4oc5Vy6X%3DQHN82GT%3DB_rtqSXgn3R4RL_bhhNtexvw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
