I posted a positive review on the trac server.
Anne
bump wrote:
I made these changes and also added Nicolas as an author. The
reposted patch is on the trac server.
Dan
If you (Dan and Nicolas) would like to submit the patch jointly,
I am happy to review. Here are a couple of small comments:
- Perhaps it would be better to name the file
sage.algebras.iwahori_hecke_algebra or
sage.algebras.iwahori_hecke ?
- line 221 in algebra/iwahori.py
coxeter group -> Coxeter group
Other than that, I would be happy to set a positive review.
--
You received this message because you are subscribed to the Google Groups
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-de...@googlegroups.com.
To unsubscribe from this group, send email to
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sage-combinat-devel?hl=en.
